setAttribute('style', ...) workaround for IE

node.style.cssText = "..." usually does the trick for me

thanks, it works well!

BEFORE

var closer = document.createElement('a');
//a.setAttribute('style', 'float:left; font-weight:bold');

_setStyle(a, 'float:left; font-weight:bold');
a.onclick = function() { ... }

----------------------
AFTER

var closer = document.createElement('a');
//closer.setAttribute('style', 'float:left; font-weight:bold');

_setStyle(closer, 'float:left; font-weight:bold');
closer.onclick = function() { ... }

If type 'closer' it's work

Thanks Peter :D

Just what I was looking for.

Thanks a lot!

Wow that was great buddy ! You saved me a lot of weeks. I need to personally thanks you too.

Hi, it helped me to fix appending of new style values, without overwritting all previously declared ones (just those that are meant to change). Thanks.
If you still don't like eval(), try this:
element.style[k]= v;
You know objects, arrays, objects...

Thanks a lot! perfect code!!!

This is great! I've improved it just a bit:

_setStyle: function (aElement /* object */, aDeclaration /* CSS Declaration */) {
try {
if (aElement) {
aDeclaration = aDeclaration.replace(/\s+/g,''); // remove all white spaces
if (document.all) { // IE Hack
if (aDeclaration.charAt(aDeclaration.length-1)==';')
aDeclaration = aDeclaration.slice(0, -1);
var k, v;
var splitted = aDeclaration.split(';');
for (var i=0, len=splitted.length; i<len; i++) {
k = rzCC(splitted[i].split(':')[0]);
v = splitted[i].split(':')[1];
eval("aElement.style."+k+"='"+v+"'");
}
return (true);
} else { // The clean way
aElement.setAttribute ('style', aDeclaration);
return (true);
}
}
} catch (e) {
return (false);
}
}

Hope you like it. Good job mate ;)

I forgot to tell why I decided to "improve" it: if you put a white space in the css declaratio, such:

background-color: #FFFFFF;

the original code will miss it. You had to put it together for it to work, like:

background-color:#FFFFFF;

Oh, and the function declaration in my version is for prototype. If you don't use this technique just change the declaration to:

function _setStyle (aElement /* object */, aDeclaration /* CSS Declaration */)

That's it.

Cheers!

I found myself having issues with this same problem today and have found out a few interesting things.

In IE (they just have to be different don't they) the style attribute is actually treated as an Element. You can set the different style properties by using the syntax shown below.

oNewDiv = createElement('div');
oNewDiv.style.setAttribute('border', '1px solid #000');
oNewDiv.style.setAttribute('backgroundColor', '#fff');

Of course, this fails terribly in firefox :(

However, I have always been able to set styles without the setAttribute function in a cross browser supported way like:

oNewDiv.style.backgroundColor = '#fff';

This won't work at all for me, using IE 7 or 8..

eval() is devil. this workaround is not going to help. infact it will hang your IE and fill your memory with bunch of variables.

If you code little smart using conditions if(document.all) { code here }else{ code here } then everything will be cool.

I've tried and it's working in all browsers.

Try using cssText for ie.
Element.style.setAttribute('cssText', 'left:150px;.........
you could create function if you wanted.

thanks very very very much!

@ivo van der Wijk=You're a genius man!!!
I know it sounds very exagerrated but what the hell... u just saved me a couple of hours of searching

Hi,

Try this:

var closer = document.createElement('a');
a.style.float="left";
a.style.fontWeight="bold";
a.onclick = function() { ...

It works on all browsers !! Enjoy it !!

Hi,
how is this?
element.style[k]= v;
instead of eval(...)

Cool!!
thxs!

Works like a charm! I definitely needed this dynamic!! Thanks so much!

I like how you automatically escaped the newline in the commented code ;-P

set one or more objects to one or more styles
{obj1,obj2...},{"color":"red","fontSize":"small","fontFamily":"Cursive"...}
works in FF,IE,Safari

function a_obj_setstyle(a_obj,a_prop){
for (ko in a_obj){for(kp in a_prop){
eval('a_obj[ko].style.'+kp+'="'+a_prop[kp]+'"');
}}
}

OMG, your a very smart, you just saved my ass, my client was going to kill me ,, lol

Thanks a lot body ;)

This is how it works in IE

oImg.style.cssText="float:left;margin-right:7px;margin-bottom:7px";

THAAAAANXXXXXX!!!!
You're the best web programmer!!!!!

I hate IE...

Thanks a lot!!!!

Hello guys,

If you have short form in your style like :

font: normal normal bold xx-small verdana, serif;

This cut function will cut the spaces and mix the css -->
font:normalnormalboldxx-smallverdana,serif;

Oh thats work great... thankssssssss.....

I had a similar issue with setAttribute not working on IE. I put it in a try block, and in the catch block I used outerHTML for the IE version. outerHTML is read/write, so my function could dynamically get the code of the existing control, and then replace whatever had to change. One quirk is that IE rewrites the control's code in outerHTML, so I had to work around that a little, but it worked.

thanks ur code, but if i want to remove one of css that i added, how can i do that????

document.getElementById('name').className = "yourClass";

People, DO NOT USE eval(). Especially not in such an easy cases.

eval("element.style."+k+"='"+v+"'");
is almost identical (I'll explain) to this:
element.style[k] = v;

When you create an object: var obj = { a: 1, b: 2, c: 3 };
You can (get or) set the values like:
obj.a = 10
which is identical to:
obj["a"] = 10

As to where that eval("element.style."+k+"='"+v+"'"); differs from the direct method is that if you'd try to set for example a background image, this'd be the css:
background-image: url('/images/someImage.png')
If you use that in the eval, this is the code that'll be evaluated:
element.style.backgroundImage='url('/images/someImage.png')'
Which obviously results in a syntax error because of the single quotes. Of course that could be solved by first replacing \ into \\ and then ' into \'.

Eval is evil, there are rarely ever situations where there's need for eval, and even if there are try your absolute best to find a way around.
Such a small change avoids:
1. The performance hit you have from using eval()
2. Making your code less secure (for example, if some 3rd party code executes: _setStyle(someElement, "width: 10px' alert('My evil message, muauauauaua') var rndDump = '; height: 10px;"), it would of course run the injected code)
3. Spreading bad code like this across other people's sites, possibly harming the identity and privacy of people browsing the web.